Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fix regressions #2199

Merged
merged 3 commits into from
Mar 6, 2018
Merged

[docs] fix regressions #2199

merged 3 commits into from
Mar 6, 2018

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Mar 3, 2018

Changes proposed in this pull request:

Fix #2163: give ModifierTable its own class. stop reusing .docs-modifiers, which was the cause of this issue.

Fix #2194: tree caret icon rotation

Fix #2177: move pt-running-text back to docs-section. oof, preempts so many other tiny regressions!

@giladgray giladgray requested a review from adidahiya March 3, 2018 23:41
@blueprint-bot
Copy link

give ModifierTable its own class. fixes #2163

Preview: documentation | landing | table

@giladgray giladgray changed the title [docs] fix API browser scroll #2163 [docs] fix regressions Mar 3, 2018
@blueprint-bot
Copy link

fix tree icon

Preview: documentation | landing | table

Copy link
Contributor

@themadcreator themadcreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@llorca llorca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the tree should have chevrons, not caret. when did that change?

@giladgray
Copy link
Contributor Author

@llorca i made that change at some point. the classes have always used the word caret, and every other file tree i could find uses carets (not chevrons).

@giladgray giladgray merged commit 8396c0d into develop Mar 6, 2018
@giladgray giladgray deleted the gg/docs-visuals branch March 6, 2018 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants