Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Add Icon title prop #2182

Merged
merged 1 commit into from
Feb 25, 2018
Merged

[core] Add Icon title prop #2182

merged 1 commit into from
Feb 25, 2018

Conversation

reiv
Copy link
Contributor

@reiv reiv commented Feb 24, 2018

Fixes #2160

Changes proposed in this pull request:

Adds a title prop to Icon, allowing consumers to override or disable the hover text.

@reiv reiv changed the title [core] Add Icon title prop (#2160) [core] Add Icon title prop Feb 24, 2018
@reiv
Copy link
Contributor Author

reiv commented Feb 25, 2018

[core] Add Icon `title` prop (#2160)

Preview: documentation | landing | table

adidahiya
adidahiya approved these changes Feb 25, 2018
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks @reiv

@adidahiya adidahiya merged commit ada588c into palantir:develop Feb 25, 2018
@reiv reiv deleted the rv/icon-title branch February 26, 2018 01:04
@giladgray giladgray mentioned this pull request Mar 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reiv @adidahiya