allow React 16 in core peerDependencies #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade support seems free since there were no warnings with latest 15.x release.
adidahiya
approved these changes
Oct 4, 2017
|
|
allow react 16 in core peerDepsPreview: documentation | table |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #866
Changes proposed in this pull request:
Allow React 16 to be installed alongside Blueprint.
This does not guarantee full support for React 16, but I've manually tested locally and all components render without errors. There may still be issues with deeper interaction logic (though I'm optimistic they'll be very rare), so at least this way folks can encounter those bugs and report them!
Note that until we begin work on 2.0, we are not doing any automated testing against React 16 (see #1659). We are also still using (very old) React typings (see #1031).