[Table] Fix missing selection border on left edge of grid #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmslewis
commented
Sep 26, 2017
| @@ -104,6 +104,13 @@ $table-quadrant-scroll-container-overflow: 20px; | |||
| height: auto; | |||
| overflow-x: hidden; | |||
| } | |||
|
|
|||
| // correct missing left selecton border when selection includes | |||
| // cells in the first column (#516). we do this by requiring at least | |||
Fix commentPreview: documentation | table |
llorca
approved these changes
Sep 26, 2017
There was a problem hiding this comment.
Works as expected, but it's really awkward that we have this blue line staying around on scroll, only when a selection is on the edge of a region.
I wouldn't mind having the blue line sticking around if the behavior was consistent no matter what the selection is, but I still think the ideal scenario is no blue line visible on scroll
|
@llorca I agree. I have a potential fix in mind. |
This was referenced Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addreses #1444
Changes proposed in this pull request:
Tablenow displays a left border on selections that are flush with the left side of the grid.Reviewers should focus on:
LEFTandTOP_LEFTquadrants when they're not needed. :)Screenshot