[Table/Core] Move some table utils into core

[cmslewis]

Fixes #1601

Changes proposed in this pull request:

• 🔄 CHANGED The following packages/table utils now live in packages/core:
  • arraysEqual
  • deepCompareKeys
  • getDeepUnequalKeyValues
  • getShallowUnequalKeyValues
  • shallowCompareKeys

This change is necessary to unblock PR #1492.

Reviewers should focus on:

• I updated all references to these utils throughout packages/table.
• I renamed BlueprintUtils to CoreUtils throughout packages/table. Now everything is consistent.
• I left facades in packages/table/src/common/utils so as to not break the public API; the table utils are exported after all. All those facades include function descriptions identical to the ones in packages/core/src/common/utils, except they include @deprecated warnings.
• Anyone know how to import interfaces like IKeysWhitelist an IKeysBlacklist from core, and re-export them from table? Tried and failed to do that syntactically, so I just redefined the interfaces in table.
• Is it possible to use the { utilName: CoreUtils.utilName } pattern if CoreUtils.utilName is generically typed? Couldn't get that to work either, so I spelled out the functions more verbosely.

[gscshoyru]

Seems simple enough? I'm not sure on the typings questions, though, I'd need to be playing with it locally myself I think to be able to grok what you're talking about, sorry.

[blueprint-bot]

Fix build

Preview: documentation | table
Coverage: core | datetime

[cmslewis]

@llorca feel free to toss this into this week's release

[cmslewis]

@llorca if this PR makes it into this week's release, I believe this table version would be correct, right?

[llorca]

Correct! Can we explicitly say @deprecated since @blueprintjs/table 1.26.0 (not sure if we have a pattern for that) to avoid confusion with the generic/core version?

[giladgray]

how about compareUtils.ts for all these new functions? there's a lot of code there and utils.ts becomes unmaintainably long.

[llorca]

@giladgray why not a utils/ folder

[giladgray]

@llorca we should definitely make a utils/ folder, but not in this PR.

[cmslewis]

how about compareUtils.ts for all these new functions

@giladgray yes please

[cmslewis]

@giladgray @llorca though in making compareUtils.ts, I'm struggling with two things:

1. There are other, existing comparison-oriented functions like arrayLengthCompare and approxEqual. Should those live in compareUtils.ts too?
2. I'd rather not export a bunch of different *Utils.ts files from Core, but I also can't do something like export * from "./compareUtils.ts" from a common, top-level utils.ts file. We okay with me importing functions by name into utils.ts and then exporting all of them individually? Derp brain fart. Of course you can.

[blueprint-bot]

Move code into utils/compareUtils.ts

Preview: documentation | table
Coverage: core | datetime

Addressed comments

[cmslewis]

Should now change to 1.27.0 since we didn't make last week's release

[themadcreator]

Looks good.

I would have thought export { IKeysWhiteList } from "..." would have worked.

[cmslewis]

@themadcreator fortunately it's easy to play with that without affecting the API now. maybe i'll figure something out after merging.