Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs2] clicking selected tab again fires onChange #1069

Merged
merged 1 commit into from
May 9, 2017
Merged

[Tabs2] clicking selected tab again fires onChange #1069

merged 1 commit into from
May 9, 2017

Conversation

giladgray
Copy link
Contributor

Fixes #1067

cc @jkillian

As easy as removing an if statement!

@blueprint-bot
Copy link

[Tabs2] clicking selected tab again fires onChange

Preview: documentation
Coverage: core | datetime

@cmslewis
Copy link
Contributor

cmslewis commented May 9, 2017

I've occasionally found that it's helpful to disable clicking on a selected tab. For users who want that, seems like adding a custom pointer-events: none style would both prevent clicks and prevent onChange from being fired, yes?

@adidahiya
Copy link
Contributor

yeah I think pointer-events should do it

@giladgray giladgray merged commit 5bfa836 into master May 9, 2017
@giladgray giladgray deleted the gg/tabs2-click-again branch May 9, 2017 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkillian jkillian jkillian approved these changes

@adidahiya adidahiya adidahiya approved these changes

@cmslewis cmslewis cmslewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@giladgray @blueprint-bot @cmslewis @adidahiya @jkillian