Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circle artifacts from forks die due to undefined NODE_ENV #451

Closed
giladgray opened this issue Jan 11, 2017 · 1 comment
Closed

Circle artifacts from forks die due to undefined NODE_ENV #451

giladgray opened this issue Jan 11, 2017 · 1 comment
Assignees
@giladgray
Labels
Domain: tooling Type: bug
Milestone
1.6.0

Comments

@giladgray
Copy link
Contributor

Bug report

Steps to reproduce

  1. navigate to the Circle build from a fork (such as https://circleci.com/gh/greglo/blueprint/19#artifacts/containers/0)
  2. open the packages/docs/dist/index.html artifact (https://19-76082203-gh.circle-artifacts.com/0/home/ubuntu/blueprint/packages/docs/dist/index.html)

Actual behavior

Uncaught ReferenceError: test is not defined
    at Object.<anonymous> (invariant.js:26)

Expected behavior

Site renders
@giladgray
Copy link
Contributor Author

giladgray commented Jan 11, 2017 •
edited
Loading

This should be easily fixable globally by doing npm run gulp instead of gulp build in circle.yml because the npm script sets NODE_ENV manually.

@giladgray giladgray changed the title Circle artifacts from forks don't load because of undefined NODE_ENV Circle artifacts from forks die due to undefined NODE_ENV Jan 11, 2017
@giladgray giladgray mentioned this issue Jan 11, 2017
Merged
giladgray added a commit that referenced this issue Jan 11, 2017
@giladgray
run NPM build task which sets NODE_ENV
a7f051a 
so external contributors don't have to set the environment variable manually on circle.
fixes #451
@giladgray giladgray mentioned this issue Jan 11, 2017
Merged
giladgray added a commit that referenced this issue Jan 11, 2017
@giladgray
run NPM build task which sets NODE_ENV (#455)
68792b1 
so external contributors don't have to set the environment variable manually on circle.
fixes #451
@giladgray giladgray added this to the 1.6.0 milestone Jan 13, 2017
@giladgray giladgray self-assigned this Jan 13, 2017
@giladgray giladgray mentioned this issue Jan 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giladgray giladgray

Labels
Domain: tooling Type: bug
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
1 participant
@giladgray