-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove custom configuration of scss stylelint rules #411
Comments
what's wrong with max line length? |
Why do we need a custom line length limit? We should just use whatever is prescribed in stylelint-config-palantir. |
do you really want me to rewrap all those documentation paragraphs? those are the only long lines. |
the line length affects every single scss file |
ok so 100-character lines are pretty reasonable even for the docs comments, but there are a few cases where longer lines are unavoidable (such as extremely long URLs) and it's cumbersome to disable stylelint for a block comment. we could leverage the new |
In particular,
max-line-length
andat-extend-no-missing-placeholder
. This project isn't really special enough to skip those rules. We should either fix the violations or updatestylelint-config-palantir
to reflect how we really write code.blueprint/.stylelintrc
Line 9 in 31476f9
The text was updated successfully, but these errors were encountered: