Add code syntax theme to docs #405
Conversation
we've been highlighting this whole time, just not coloring. tried to minimize magic in code, but i couldn't help myself a few times.
| ); | ||
|
|
||
|
|
||
| @mixin syntax($scopes) { |
There was a problem hiding this comment.
minor: calling this argument "scopes" is a little confusing; I would just call it "colors" or something
| } | ||
|
|
||
| &.pseudo-element { | ||
| @extend .tag; |
There was a problem hiding this comment.
shouldn't this be a lint error? we should be using the placeholder-in-extends rule..?
There was a problem hiding this comment.
i think we disabled that nonsense cuz we moved our placeholders to mixins.
There was a problem hiding this comment.
I don't see why that justifies disabling the rule? If we aren't using placeholders, then there should really be no reason to use @extends at all...
There was a problem hiding this comment.
you'll notice i didn't disable the rule here. it's always been like this.
this seems like a valid use of @extend: i want one selector to behave exactly like another, in a very controlled way.
There was a problem hiding this comment.
searching for usages of @extend reveals more instances of what i'm doing here: https://github.com/palantir/blueprint/search?utf8=%E2%9C%93&q=extend&type=Code
There was a problem hiding this comment.
Yeah, I know it hasn't been disabled inline, I'm just alarmed that this passed lint because I expected the rule to be enabled across the codebase.
There's a good reason the lint rule is there. Basically every time it's been circumvented has been regretful. But this is in the docs site so I don't mind being lenient about it. Still should be accompanied with a stylelint-disable flag to make it stand out.
There was a problem hiding this comment.
There was a problem hiding this comment.
ok, now we have an objectively better solution that involves a whopping zero @extends 🛠
adidahiya
changed the title
Fixes #98