Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu items] Broken large styles #2281

Closed
llorca opened this issue Mar 20, 2018 · 3 comments · Fixed by #2285
Closed

[Menu items] Broken large styles #2281

llorca opened this issue Mar 20, 2018 · 3 comments · Fixed by #2285
Assignees
@giladgray
Labels
Domain: design Package: core Type: bug
Milestone
2.0.0

Comments

@llorca
Copy link
Contributor

llorca commented Mar 20, 2018 •
edited
Loading

image
with 2.0, large menu item styles are a bit broken:

  • the vertical centering is off, as well
  • the icon is 16px instead of 20px

Expected

image
@llorca llorca added this to the 2.0.0 milestone Mar 20, 2018
@giladgray
Copy link
Contributor

@llorca you can't just slap the .pt-large modifier and expect things to work anymore... icons can only be made large through JS.

@giladgray
Copy link
Contributor

you'll notice that the CSS API example looks great when large.

@giladgray
Copy link
Contributor

we should add large support to the JS API, though. seems that's missing.

@giladgray giladgray self-assigned this Mar 20, 2018
@giladgray giladgray mentioned this issue Mar 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giladgray giladgray

Labels
Domain: design Package: core Type: bug
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

[menu] fix large menu items palantir/blueprint
2 participants
@llorca @giladgray