Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[menu] fix large menu items #2285

Merged
merged 2 commits into from
Mar 21, 2018
Merged

[menu] fix large menu items #2285

merged 2 commits into from
Mar 21, 2018

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Mar 20, 2018 •
edited
Loading

Fixes #2281, follow up from #2265

Changes proposed in this pull request:

  • menu items align all children to flex-start
  • fix top margin for SVG icons in large menu item

cc @reiv

@giladgray giladgray requested a review from llorca March 20, 2018 23:37
@blueprint-bot
Copy link

fix top margin for SVG icons in large menu item

Preview: documentation | landing | table

themadcreator
themadcreator approved these changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@themadcreator themadcreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to audit internal SASS usage of this mixin

llorca
llorca approved these changes Mar 21, 2018
View reviewed changes
Copy link
Contributor

@llorca llorca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👌

@giladgray giladgray merged commit 6755cac into develop Mar 21, 2018
@giladgray giladgray deleted the gg/large-menu-items branch March 21, 2018 17:10
This was referenced Mar 21, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themadcreator themadcreator themadcreator approved these changes

@llorca llorca llorca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Menu items] Broken large styles
4 participants
@giladgray @blueprint-bot @llorca @themadcreator