Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card missing onDragStart, onMouseEnter, and onMouseLeave event handlers #2181

Closed
shravan2x opened this issue Feb 24, 2018 · 1 comment · Fixed by #2269
Closed

Card missing onDragStart, onMouseEnter, and onMouseLeave event handlers #2181

shravan2x opened this issue Feb 24, 2018 · 1 comment · Fixed by #2269
Assignees
@giladgray
Labels
help wanted Package: core Type: feature request
Milestone
2.0.0

Comments

@shravan2x
Copy link

Bug report

  • Package version(s): ^1.35.4
  • Browser and OS versions: Chrome 64.0.3282.167, Windows 10

Steps to reproduce

  1. Create an element
<Card onDragStart={this.handleDrag} onMouseEnter={this.handleMouseEnter} onMouseLeave={this.handleMouseLeave}>

Actual behavior

Respective events are called when dragged, mouse entered, or mouse left.

Expected behavior

Nothing happens.
@giladgray
Copy link
Contributor

giladgray commented Mar 2, 2018 •
edited
Loading

easy fix: Card should support html props, like many other components do. see tag.tsx, for instance.

@giladgray giladgray mentioned this issue Mar 19, 2018
Merged
@giladgray giladgray added this to the 2.0.0 milestone Mar 19, 2018
@giladgray giladgray self-assigned this Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giladgray giladgray

Labels
help wanted Package: core Type: feature request
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

use HTMLAttributes instead of HTMLProps palantir/blueprint
3 participants
@giladgray @adidahiya @shravan2x