use HTMLAttributes instead of HTMLProps #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure HTMLAttrs appears last in extends list
fix buttons HTMLAttributesPreview: documentation | landing | table |
Card supports HTML propsPreview: documentation | landing | table |
llorca
reviewed
Mar 19, 2018
| @@ -56,7 +56,10 @@ export interface IButtonState { | |||
| isActive: boolean; | |||
| } | |||
|
|
|||
| export abstract class AbstractButton<T> extends React.Component<React.HTMLProps<T> & IButtonProps, IButtonState> { | |||
| export abstract class AbstractButton<H extends React.HTMLAttributes<any>> extends React.PureComponent< | |||
There was a problem hiding this comment.
emoji didn't come though, it's just a square. what's the sentiment here?
There was a problem hiding this comment.
(High Sierra update is worth the new emojis. Maybe.)
giladgray
commented
Mar 19, 2018
| @@ -10,8 +10,7 @@ import * as Classes from "../../common/classes"; | |||
| import { IProps } from "../../common/props"; | |||
|
|
|||
| // allow the empty interface so we can label it clearly in the docs | |||
| // tslint:disable-next-line:no-empty-interface | |||
| export interface INavbarDividerProps extends React.HTMLProps<HTMLDivElement>, IProps { | |||
| export interface INavbarDividerProps extends IProps, React.HTMLAttributes<HTMLDivElement> { | |||
There was a problem hiding this comment.
pro tip: div and span don't have special attrs so they both use HTMLAttributes<T> but other elements like label or input have their own LabelHTMLAttributes<T> interfaces
HTMLDivProps type aliasPreview: documentation | landing | table |
themadcreator
approved these changes
Mar 19, 2018
| @@ -48,7 +48,7 @@ export interface IInputGroupState { | |||
| rightElementWidth?: number; | |||
| } | |||
|
|
|||
| export class InputGroup extends React.PureComponent<HTMLInputProps & IInputGroupProps, IInputGroupState> { | |||
| export class InputGroup extends React.PureComponent<IInputGroupProps & HTMLInputProps, IInputGroupState> { | |||
There was a problem hiding this comment.
extend interface instead of & the types (as per convention elsewhere)
comment about input group propsPreview: documentation | landing | table |
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #2266. fixes #2181.
ensure
HTMLAttributesappears last in extends list (otherwise it breaks the interface tables)