Revert "[core] fix(TagInput): restore type signature of onRemove prop (…

…#4350)" This reverts commit be7e912.
palantir · Oct 15, 2020 · f4313f0 · f4313f0
1 parent 2981d80
commit f4313f0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/core/src/components/tag-input/tagInput.tsx b/packages/core/src/components/tag-input/tagInput.tsx
@@ -139,7 +139,7 @@ export interface ITagInputProps extends IIntentProps, IProps {
      * Callback invoked when the user clicks the X button on a tag.
      * Receives value and index of removed tag.
      */
-    onRemove?: (valueAsString: string, index: number, value: React.ReactNode) => void;
+    onRemove?: (value: React.ReactNode, index: number) => void;
 
     /**
      * Input placeholder text which will not appear if `values` contains any items
@@ -466,7 +466,7 @@ export class TagInput extends AbstractPureComponent2<ITagInputProps, ITagInputSt
     /** Remove the item at the given index by invoking `onRemove` and `onChange` accordingly. */
     private removeIndexFromValues(index: number) {
         const { onChange, onRemove, values } = this.props;
-        onRemove?.(values[index]?.toString() ?? "", index, values[index]);
+        onRemove?.(values[index], index);
         if (Utils.isFunction(onChange)) {
             onChange(values.filter((_, i) => i !== index));
         }

diff --git a/packages/core/test/tag-input/tagInputTests.tsx b/packages/core/test/tag-input/tagInputTests.tsx
@@ -116,7 +116,7 @@ describe("<TagInput>", () => {
         const wrapper = mount(<TagInput onRemove={onRemove} values={VALUES} />);
         wrapper.find("button").at(1).simulate("click");
         assert.isTrue(onRemove.calledOnce);
-        assert.sameMembers(onRemove.args[0], [VALUES[1], 1, VALUES[1]]);
+        assert.sameMembers(onRemove.args[0], [VALUES[1], 1]);
     });
 
     describe("onAdd", () => {
@@ -294,7 +294,7 @@ describe("<TagInput>", () => {
             assert.equal(wrapper.state("activeIndex"), VALUES.length - 2);
             assert.isTrue(onRemove.calledOnce);
             const lastIndex = VALUES.length - 1;
-            assert.sameMembers(onRemove.args[0], [VALUES[lastIndex], lastIndex, VALUES[lastIndex]]);
+            assert.sameMembers(onRemove.args[0], [VALUES[lastIndex], lastIndex]);
         });
 
         it("pressing left arrow key navigates active item and backspace removes it", () => {
@@ -309,7 +309,7 @@ describe("<TagInput>", () => {
 
             assert.equal(wrapper.state("activeIndex"), 0);
             assert.isTrue(onRemove.calledOnce);
-            assert.sameMembers(onRemove.args[0], [VALUES[1], 1, VALUES[1]]);
+            assert.sameMembers(onRemove.args[0], [VALUES[1], 1]);
         });
 
         it("pressing left arrow key navigates active item and delete removes it", () => {
@@ -326,7 +326,7 @@ describe("<TagInput>", () => {
             // we rather "take the place" of the item we just removed
             assert.equal(wrapper.state("activeIndex"), 1);
             assert.isTrue(onRemove.calledOnce);
-            assert.sameMembers(onRemove.args[0], [VALUES[1], 1, VALUES[1]]);
+            assert.sameMembers(onRemove.args[0], [VALUES[1], 1]);
         });
 
         it("pressing delete with no selection does nothing", () => {