This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
[ASTS] feat(bucket-retrieval): Sweep timestamp manager #7184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdaudali
force-pushed
the
mdaudali/asts/dynamictaskscheduler
branch
from
eff9e51 to
9e296fd
Compare
mdaudali
force-pushed
the
mdaudali/asts/sweeptimestampmanager
branch
from
2b96394 to
f64154f
Compare
mdaudali
force-pushed
the
mdaudali/asts/dynamictaskscheduler
branch
from
b41a67a to
fd9dd19
Compare
mdaudali
force-pushed
the
mdaudali/asts/sweeptimestampmanager
branch
from
f64154f to
60b0f51
Compare
mdaudali
force-pushed
the
mdaudali/asts/sweeptimestampmanager
branch
from
60b0f51 to
8b9509e
Compare
mdaudali
changed the base branch from
mdaudali/asts/dynamictaskscheduler
to
develop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
Before this PR:
No implementation for getting the sweep timestamps
After this PR:
Now we do - a very simple wrapper
==COMMIT_MSG==
==COMMIT_MSG==
Priority: P2
Concerns / possible downsides (what feedback would you like?):
no tests, because there's nothing really to test other than are we calling and putting the correct long in the correct builder slot, which I'm not convinced a test is that valuable.
Is documentation needed?:
N/A
Compatibility
Does this PR create any API breaks (e.g. at the Java or HTTP layers) - if so, do we have compatibility?:
No
Does this PR change the persisted format of any data - if so, do we have forward and backward compatibility?:
No
The code in this PR may be part of a blue-green deploy. Can upgrades from previous versions safely coexist? (Consider restarts of blue or green nodes.):
Yes
Does this PR rely on statements being true about other products at a deployment - if so, do we have correct product dependencies on these products (or other ways of verifying that these statements are true)?:
No
Does this PR need a schema migration?
No
Execution
How would I tell this PR works in production? (Metrics, logs, etc.):
Sweep works
Has the safety of all log arguments been decided correctly?:
N/A
Scale
Would this PR be expected to pose a risk at scale? Think of the shopping product at our largest stack.:
No
Would this PR be expected to perform a large number of database calls, and/or expensive database calls (e.g., row range scans, concurrent CAS)?:
N/A
Would this PR ever, with time and scale, become the wrong thing to do - and if so, how would we know that we need to do something differently?:
N/A
Development Process
Where should we start reviewing?:
DSSTM
If this PR is in excess of 500 lines excluding versions lock-files, why does it not make sense to split it?:
Please tag any other people who should be aware of this PR:
@jeremyk-91
@sverma30
@raiju