This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
atlasdb-tests-shared #6884
Merged
atlasdb-tests-shared #6884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barisoyoruk
force-pushed
the
boy/junit5-cleanup7
branch
from
bdf6aec to
826ec1b
Compare
barisoyoruk
commented
Nov 30, 2023
Comment on lines
+57
to
+58
| /* TODO(boyoruk): fix this test */ | ||
| @Disabled |
There was a problem hiding this comment.
This was not running before because it was under the main package. Now it keeps failing for all tests so it should be further investigated after the clean up.
barisoyoruk
commented
Nov 30, 2023
Comment on lines
-68
to
-75
| @DataPoints | ||
| public static ConflictHandler[] conflictHandlers = ConflictHandler.values(); | ||
| private static List<ConflictHandler> conflictHandlers() { | ||
| return Arrays.asList(ConflictHandler.values()); | ||
| } | ||
|
|
||
| public CommitLockTest() { | ||
| super(TRM, TRM); | ||
| } | ||
|
|
||
| @Theory |
There was a problem hiding this comment.
As far as I understand, theories work in the following way:
- We obtain the Cartesian product of data points and feed them to each test.
Since we have only one data point, we didn't need to use the theory in the first place. Anyway, it is not supported in JUnit5, so just use the parameterized test.
barisoyoruk
force-pushed
the
boy/junit5-cleanup7
branch
from
1371bb3 to
75ccbd4
Compare
LucasIME
approved these changes
Dec 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this issue, we are transitioning our test classes from JUnit4 to JUnit5.
In this pull request, we are cleaning leftover implementations, mainly by removing V1s and renaming V2s. This PR is for package
atlasdb-tests-shared