This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
[CBT] Retry flaky tests #6541
Merged
[CBT] Retry flaky tests #6541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
jeremyk-91
reviewed
Apr 24, 2023
| @@ -128,6 +128,7 @@ public void before() { | |||
| LockWatchIntegrationTestUtilities.awaitTableWatched(txnManager, TABLE_REF); | |||
| } | |||
|
|
|||
| @ShouldRetry | |||
There was a problem hiding this comment.
I think you can put this at the class-level? (It seems like this is on almost all if not all the methods.) You can override this to be 15 specifically on that one test
There was a problem hiding this comment.
It is already on this class which I've missed!
Overriding to 15 for all tests given that it retries for all the tests
ergo14
commented
Apr 26, 2023
Comment on lines
+53
to
56
| @ShouldRetry | ||
| @Test | ||
| public void dynamicRandomColumns() { | ||
| ThreadLocalRandom random = ThreadLocalRandom.current(); |
There was a problem hiding this comment.
According to circle, this succeeds 80% of the time
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.