This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
[PDS-344883] Async Initialisation and Profiling #6485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
Before this PR:
Debugging cases where a task in async initialization gets stuck can be tricky, especially at deployments where one does not have easy access to logs, or if users submit complex async initialisation tasks.
After this PR:
==COMMIT_MSG==
Asynchronous initialisation now logs when the initialisation an individual object starts, as well as when the executor is shutdown.
==COMMIT_MSG==
Priority: P2
Concerns / possible downsides (what feedback would you like?): Noisy logs?
Is documentation needed?: No
Compatibility
Does this PR create any API breaks (e.g. at the Java or HTTP layers) - if so, do we have compatibility?: No
Does this PR change the persisted format of any data - if so, do we have forward and backward compatibility?: No
The code in this PR may be part of a blue-green deploy. Can upgrades from previous versions safely coexist? (Consider restarts of blue or green nodes.): Yes
Does this PR rely on statements being true about other products at a deployment - if so, do we have correct product dependencies on these products (or other ways of verifying that these statements are true)?: No
Does this PR need a schema migration? No
Testing and Correctness
Logging only.
Execution
How would I tell this PR works in production? (Metrics, logs, etc.): The logs are visible.
Has the safety of all log arguments been decided correctly?: I believe so: nothing changed from previous iterations.
Will this change significantly affect our spending on metrics or logs?: No, I don't think so.
How would I tell that this PR does not work in production? (monitors, etc.): The logs are not visible, or they cause massive explosions.
If this PR does not work as expected, how do I fix that state? Would rollback be straightforward?: Recall and rollback
If the above plan is more complex than “recall and rollback”, please tag the support PoC here (if it is the end of the week, tag both the current and next PoC):
Scale
Would this PR be expected to pose a risk at scale? Think of the shopping product at our largest stack.: No
Would this PR be expected to perform a large number of database calls, and/or expensive database calls (e.g., row range scans, concurrent CAS)?: No
Would this PR ever, with time and scale, become the wrong thing to do - and if so, how would we know that we need to do something differently?: Maybe if the logging gets too costly.
Development Process
Where should we start reviewing?: Small
If this PR is in excess of 500 lines excluding versions lock-files, why does it not make sense to split it?: No
Please tag any other people who should be aware of this PR:
@jeremyk-91
@sverma3
@raiju