This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
BackupService backwards compatibility #6040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
Jolyon-S
reviewed
May 18, 2022
| log.info( | ||
| "Successfully loaded file", | ||
| SafeArg.of("fileName", file.getName()), | ||
| SafeArg.of("namespace", atlasService)); |
There was a problem hiding this comment.
non-blocking: you've reverted this name
Jolyon-S
approved these changes
May 18, 2022
When we need this object mapper, we will probably need it many times. So let's create it at most once.
Jolyon-S
reviewed
May 26, 2022
Comment on lines
55
to
56
| this.legacyObjectMapper = Suppliers.memoize( | ||
| () -> OBJECT_MAPPER.copy().setPropertyNamingStrategy(PropertyNamingStrategies.KEBAB_CASE)); |
There was a problem hiding this comment.
is there any reason we can't just have a second static?
There was a problem hiding this comment.
I guess we could - we most likely won't need to initialize this, but doing so can't be that expensive, and it'd make the code a little simpler.
|
Released 0.617.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
==COMMIT_MSG==
==COMMIT_MSG==
Implementation Description (bullets):
Testing (What was existing testing like? What have you done to improve it?):
Concerns (what feedback would you like?):
Where should we start reviewing?:
Priority (whenever / two weeks / yesterday):