Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

[AtlasDB Proxy & DbKVS] Part 1: Long Identifier Support in Oracle #5930

Merged
merged 15 commits into from
Mar 1, 2022

Conversation

jeremyk-91
Copy link
Contributor

Goals (and why):

  • Newer versions of Oracle support identifiers of up to 128 characters, and we use this versions. The restriction of identifiers of up to 30 characters, and for prudent reasons table prefixes of 7 characters and overflow table prefixes of 6 characters should no longer apply.
    ==COMMIT_MSG==
    ==COMMIT_MSG==

Implementation Description (bullets):

  • Configurably allow explicit support for long identifiers.
  • But only permit the use of long identifiers where table mapping is not used: we don't plan on using this in atlasdb proxy.

Testing (What was existing testing like? What have you done to improve it?):

  • Added unit tests relating to table prefixes and explicit enabling or not of long prefix names.

Concerns (what feedback would you like?):

  • Is the restriction that table mapping doesn't work nicely with this reasonable?

Where should we start reviewing?: OracleDdlConfig

Priority (whenever / two weeks / yesterday): this week please!

@changelog-app
Copy link

changelog-app bot commented Feb 28, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Support for long identifiers in Oracle KVS may be configured. This is only allowed for users that don't use table mapping.

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@gmaretic gmaretic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bulldozer-bot bulldozer-bot bot merged commit 2efb865 into develop Mar 1, 2022
@bulldozer-bot bulldozer-bot bot deleted the jkong/atlasdb-proxy-dbkvs-oracle-table-mapping branch March 1, 2022 17:53
@svc-autorelease
Copy link
Collaborator

Released 0.560.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants