This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Allow using more threads to refresh cassandra pools #5900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
sudiksha27
reviewed
Feb 11, 2022
| private static final ScheduledExecutorService sharedRefreshDaemon = | ||
| PTExecutors.newScheduledThreadPool(1, new NamedThreadFactory("CassandraClientPoolRefresh", true)); | ||
| private static final InitializeableScheduledExecutorServiceSupplier sharedExecutorSupplier = | ||
| new InitializeableScheduledExecutorServiceSupplier( |
There was a problem hiding this comment.
nit: static final should be all caps?
| supplier.get().schedule(task, 0, TimeUnit.SECONDS); | ||
| supplier.get().schedule(task, 0, TimeUnit.SECONDS); | ||
| assertThat(latch.await(1, TimeUnit.SECONDS)).isFalse(); | ||
| } |
There was a problem hiding this comment.
Hm the test makes sense.
|
The factory creation path is janky and it is okay to roll out the change now and see if this works - hopefully at some point we fix our creation paths. |
sudiksha27
approved these changes
Feb 11, 2022
|
Released 0.543.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
Currently, only a single thread does all client pool refreshes for all transaction managers. Turns out that can be too slow if we use ~100 TMs, and manifests itself in two ways: refreshes are much slower than anticipated, and we leak resources because our infinite queue constantly grows. This is not a fullproof solution, but it allows users to specify a more reasonable number of threads.
==COMMIT_MSG==
Cassandra users can now specify the number of threads to be used for refreshing pools
==COMMIT_MSG==
Implementation Description (bullets):
This is a bit on the awful side, but it is usable enough until we figure out if we want to do something better
Testing (What was existing testing like? What have you done to improve it?):
Unit tests, existing tests
Concerns (what feedback would you like?):
People can break themselves if they do things wrong, but barring really awful configurations, it shouldn't really be worse than it is now
Where should we start reviewing?:
Priority (whenever / two weeks / yesterday):
asap