This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
ABR15: "clear locks task" wiring #5892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d94823a.
Generate changelog in
|
gmaretic
approved these changes
Feb 8, 2022
|
|
||
| /** | ||
| * Disables TimeLock on all nodes for the given namespaces. | ||
| * Should be called exactly once prior to a restore operation. Calling this on multiple nodes will cause conflicts. |
There was a problem hiding this comment.
funny fact: we have a NonIdempotent annotation. Check its javadoc...
atlasdb-backup/src/main/java/com/palantir/atlasdb/backup/AtlasRestoreService.java
Outdated
Show resolved
Hide resolved
| @@ -98,16 +151,65 @@ public static AtlasRestoreService create( | |||
| Set<Namespace> namespaces, BiConsumer<String, RangesForRepair> repairTable) { | |||
| Map<Namespace, CompletedBackup> completedBackups = getCompletedBackups(namespaces); | |||
| Set<Namespace> namespacesToRepair = completedBackups.keySet(); | |||
| restoreTables(repairTable, completedBackups, namespacesToRepair); | |||
There was a problem hiding this comment.
done (also renamed the restoreTransactionsTables method below to repairTransactionsTables)
|
Released 0.538.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
Final part of the production code for Atlas Backup/Restore work stream.
Wires up the AllNodesDisabledNamespacesUpdater, added in #5876, to the TimeLockManagementResource, and adds new public methods in AtlasRestoreService.
==COMMIT_MSG==
Added AtlasRestoreService methods
prepareRestoreandcompleteRestore, which will respectively disable and re-enable TimeLock, and should be called during the restore process.==COMMIT_MSG==
Implementation Description (bullets):
Testing (What was existing testing like? What have you done to improve it?):
Concerns (what feedback would you like?):
Do we want to take the time to add retry logic now? These methods should now work end-to-end, although flakes may require manual action.
Where should we start reviewing?: AtlasRestoreService
Priority (whenever / two weeks / yesterday): ASAP, the next parts are blocked on this piece.