This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Full Circle: Reading the host location is now asynchronous #5865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
Jolyon-S
changed the title
jeremyk-91
reviewed
Jan 19, 2022
|
|
||
| /** | ||
| * Supplier that will evaluate a delegate supplier asynchronously, providing a result when the underlying computation | ||
| * is complete. This computation is only initiated after the first call to get, but will be memoized infinitely after |
There was a problem hiding this comment.
let's say that this returns Optional.empty until the result is available somewhere - that's part of the point of this
| * This class is thread safe by synchronising on {@link #get()}. | ||
| */ | ||
| @ThreadSafe | ||
| final class AsyncSupplier<T> implements Supplier<Optional<T>> { |
There was a problem hiding this comment.
nit: we should follow atlasdb conventions (public class and public factory)?
|
👍 |
|
Released 0.520.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
==COMMIT_MSG==
The host location supplier is now run in a separate thread, and will return empty while evaluating. This is particularly important when the
Ec2HostLocationSupplierrepeatedly (and slowly) fails to connect, as this is on the creation path of theCassandraClientPoolImpland thus the transaction manager creation path.==COMMIT_MSG==
Implementation Description (bullets):
Introduce
AsyncSupplierto encapsulate a supplier that should compute its result asynchronously...Testing (What was existing testing like? What have you done to improve it?):
Added a test.
Concerns (what feedback would you like?):
Where should we start reviewing?:
Diff
Priority (whenever / two weeks / yesterday):
Two years ago 🔥