Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

[LW] Add some more logging #5861

Merged
merged 2 commits into from
Jan 18, 2022
Merged

[LW] Add some more logging #5861

merged 2 commits into from
Jan 18, 2022

Conversation

Jolyon-S
Copy link
Contributor

Goals (and why):
==COMMIT_MSG==
Add additional logging when the lock watch cache falls back due to validation failures
==COMMIT_MSG==

Implementation Description (bullets):

  • add a stacktrace for when the validation fails
  • add a logline for the fallback (which can be called by itself instead of by catching an exception, and thus there isn't always a guaranteed logline present currently).

Concerns (what feedback would you like?):
While we're at it, anything else we should probably add?

Priority (whenever / two weeks / yesterday):
ASAP

@changelog-app
Copy link

changelog-app bot commented Jan 18, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Add additional logging when the lock watch cache falls back due to validation failures

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@gmaretic gmaretic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gift that keeps on giving

@bulldozer-bot bulldozer-bot bot merged commit d49d6c0 into develop Jan 18, 2022
@bulldozer-bot bulldozer-bot bot deleted the jshah/validation-logging branch January 18, 2022 12:15
@svc-autorelease
Copy link
Collaborator

Released 0.519.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants