Configurable GzipCompressingInputStream compression buffer size

[schlosna]

Goals (and why):
GzipCompressingInputStream did not allow configuring compression buffer size, leading to suboptimal compression with default DeflaterInputStream buffer size of 512 bytes.

Implementation Description (bullets):
Allow configuring the GZIP compression buffer size. Increase default compression buffer size to 64 KiB.

Testing (What was existing testing like? What have you done to improve it?):
StreamCompressionTests

Concerns (what feedback would you like?): Is 64 KiB too large default? My sense is no, and that's the current default for LZ4 block size.

Where should we start reviewing?: GzipCompressingInputStream

Priority (whenever / two weeks / yesterday): this week

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Configurable GzipCompressingInputStream compression buffer size

Goals (and why):
GzipCompressingInputStream did not allow configuring compression buffer size, leading to suboptimal compression with default DeflaterInputStream buffer size of 512 bytes.

Implementation Description (bullets):
Allow configuring the GZIP compression buffer size. Increase default compression buffer size to 64 KiB.

Testing (What was existing testing like? What have you done to improve it?):
StreamCompressionTests

Concerns (what feedback would you like?): Is 64 KiB too large default? My sense is no, and that's the current default for LZ4 block size.

Where should we start reviewing?: GzipCompressingInputStream

Priority (whenever / two weeks / yesterday): this week

Check the box to generate changelog(s)

• Generate changelog entry

[jeremyk-91]

looks good, though I think we should fix the changelog

[jeremyk-91]

💯

[jeremyk-91]

Suggested change

	description: |-
	Configurable GzipCompressingInputStream compression buffer size
	**Goals (and why)**:
	`GzipCompressingInputStream` did not allow configuring compression buffer size, leading to suboptimal compression with default `DeflaterInputStream` buffer size of 512 bytes.
	**Implementation Description (bullets)**:
	Allow configuring the GZIP compression buffer size. Increase default compression buffer size to 64 KiB.
	**Testing (What was existing testing like? What have you done to improve it?)**:
	StreamCompressionTests
	**Concerns (what feedback would you like?)**: Is 64 KiB too large default? My sense is no, and that's the current default for LZ4 block size.
	**Where should we start reviewing?**: GzipCompressingInputStream
	**Priority (whenever / two weeks / yesterday)**: this week
	<!---
	Please remember to:
	- Add any necessary release notes (including breaking changes)
	- Make sure the documentation is up to date for your change
	--->
	description: |-
	Allow configuring the GZIP compression buffer size. Increase default compression buffer size to 64 KiB.

probably an oversight

[schlosna]

yeah, we need to update PR template, created #5849 to add the ==COMMIT_MSG== section

[jeremyk-91]

🏎️ race condition

yeah this looks good 👍