This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
[Transactions3/ABR] Need to abort at the put timestamp or higher #5847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
jeremyk-91
commented
Jan 11, 2022
| @@ -123,7 +124,6 @@ public Statement bindAbortStatement(PreparedStatement preparedAbortStatement, Tr | |||
| BoundStatement bound = preparedAbortStatement.bind(rowKeyBb, columnNameBb, valueBb); | |||
| return bound.setConsistencyLevel(ConsistencyLevel.QUORUM) | |||
| .setSerialConsistencyLevel(ConsistencyLevel.SERIAL) | |||
| .setDefaultTimestamp(CellValuePutter.SET_TIMESTAMP + 1) | |||
There was a problem hiding this comment.
From javadoc of Statement#setDefaultTimestamp(long):
* <p>Note that unlike other configuration, when this statement is prepared {@link
* BoundStatement}s created off of {@link PreparedStatement} do not inherit this configuration.
There was a problem hiding this comment.
It doesn't seem like this should apply, given that we set it on the bound statement already
gmaretic
approved these changes
Jan 11, 2022
|
also need to handle STAGING (can be separate pr) |
|
It already works with STAGING? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
Implementation Description (bullets):
Testing (What was existing testing like? What have you done to improve it?):
Concerns (what feedback would you like?):
to investigate: this looks like it's set lower down, why doesn't it work already?
Where should we start reviewing?: small
Priority (whenever / two weeks / yesterday): this week please, blocks transactions3 and ABR rollouts!