Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

[Exclusion Hunter] Part 21: ModifyCollectionInEnhancedForLoop #5795

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

jeremyk-91
Copy link
Contributor

Goals (and why):

  • Don't have exclusions

Implementation Description (bullets):

  • Switch usage of removal-while-iterating-over-map to removal through an iterator.

Testing (What was existing testing like? What have you done to improve it?):

  • Existing tests

Concerns (what feedback would you like?):

  • Might this actually have different semantics?
  • I'd do the change to inclusive language another time

Where should we start reviewing?: Blacklist

Priority (whenever / two weeks / yesterday): whenever

@jeremyk-91
Copy link
Contributor Author

womp, something is not right with perms here

@jeremyk-91
Copy link
Contributor Author

ah you helped me merge, I see 👍 (and thanks for that!)

@jeremyk-91 jeremyk-91 merged commit 16588ff into develop Dec 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the jkong/change-me-please branch December 14, 2021 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants