This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABR1: AtlasBackupService #5708
ABR1: AtlasBackupService #5708
Changes from 28 commits
88d8b4c
1381ff6
2eaff3f
7caa474
ed17c4e
97b6645
f09979f
ebac8c1
f95b661
e0f9f08
001d370
b10db24
ea2d59f
1a26a56
88817a2
f4b6d16
67262e7
6e50fb7
0477db6
2df8fad
377f58c
4692100
3b4d1fe
01daad9
5169d21
7a4a422
d5a09ee
d889dac
b4ff72c
bcc700e
e3605d2
695779d
5a40e5c
25ea394
5cab1a8
2c0a021
12854d2
1959f8b
33177e0
d734333
a651ef8
7fef3bb
33ffd63
072e31b
5c31922
747944b
5a9d619
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can go with an
AtlasBackupService
that has a fixed client and the same API instead of recreating the client for each taskThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the naming is misleading you here - renaming to
AtlasBackupService
makes sense. TheserviceName
is whatever the timelock service name is configured to be internally (not connected to the namespace), and the class will be created once (on internal service startup), and reused for multiple backup operations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: actually persist the tokens using a persister that is passed in to this class, then we have an atlas-side implementation of the persister that conforms with the current backup story in internal tooling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: altas-backup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
atlasdb-backup
for consistency?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is slightly wasteful, but probably fine for API simplicity