This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Add metrics for cache instance count #5631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
Jolyon-S
reviewed
Sep 13, 2021
atlasdb-client/src/main/java/com/palantir/atlasdb/AtlasDbMetricNames.java
Outdated
Show resolved
Hide resolved
atlasdb-impl-shared/src/main/java/com/palantir/atlasdb/keyvalue/api/cache/CacheMetrics.java
Outdated
Show resolved
Hide resolved
...db-impl-shared/src/test/java/com/palantir/atlasdb/keyvalue/api/cache/CacheStoreImplTest.java
Outdated
Show resolved
Hide resolved
Jolyon-S
approved these changes
Sep 13, 2021
|
Released 0.414.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why): Start tracking the count of existing caches in metrics, to help diagnosing memory leaks such as PDS-185998 and (currently) PDS-209612.
Implementation Description (bullets):
Testing (What was existing testing like? What have you done to improve it?): Metrics are contained in a CacheMetrics class, which is usually mocked and receives some simple testing. I added a minimal assertion to one of the existing tests.
Concerns (what feedback would you like?): A single CacheMetrics instance seems to be exclusive to a single CacheStoreImpl instance, but metric names are strings registered in MetricsManager - is it certain individual gauges will be tagged appropriately?
Where should we start reviewing?: Wherever.
Priority (whenever / two weeks / yesterday): Two weeks.