Move isNewService check to TimelockAgent

[leonz]

Goals (and why):
We are looking to introduce a dynamic check for is-new-service which is not based on the static configuration supplied to Timelock. To do this, we intend to override the value supplied by configuration.

So, we need to disable the invariant check that happens on immutable creation since this may not yet be the "final" state.

Implementation Description (bullets):

• Move the invariant check to the TimelockAgent create function. I believe this is still the critical path.
• Expose the PaxosInstallConfiguration and TimelockInstallConfiguration builders so that these objects can be re-created externally.

Testing (What was existing testing like? What have you done to improve it?):
Existing unit testing should be sufficient. Unfortunately any of the testing that checks for failure needs to be moved into TimelockAgentTest.

Concerns (what feedback would you like?):

Where should we start reviewing?:

Priority (whenever / two weeks / yesterday):
ASAP

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Move isNewService check to TimelockAgent

Check the box to generate changelog(s)

• Generate changelog entry

[jeremyk-91]

👍

[svc-autorelease]

Released 0.380.0