This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
[DB TimeLock] 3A.2 Silly errors #5521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
gmaretic
approved these changes
Jun 24, 2021
|
Released 0.364.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why): Be better (more seriously, support reloading of the db password in db-timelock)
Implementation Description (bullets): Fix some little bits not noticed in round 1
Testing (What was existing testing like? What have you done to improve it?): Manual tested. There will be some tests coming in internal timelock
Concerns (what feedback would you like?): not much
Where should we start reviewing?: small
Priority (whenever / two weeks / yesterday): this week please