This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Make TransactionConflictExceptions actually useful #5497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
Jolyon-S
commented
Jun 9, 2021
Comment on lines
+927
to
+933
| throw new TransactionSerializableConflictException( | ||
| "An uncommitted conflicting read was " | ||
| + "written after our start timestamp for table " | ||
| + tableRef + ". " | ||
| + "This case can cause deadlock and is very likely to be a " | ||
| + "read write conflict.", | ||
| tableRef); |
There was a problem hiding this comment.
Spotless apparently.
|
Released 0.350.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
Conflict exceptions have a load of info that is not really useful to us as-is. Aim is to change that by recording the table - it's not logged anywhere, just accessible so that internally we can use it.
Implementation Description (bullets):
Make TCE and TSCE track the conflicting table.
Testing (What was existing testing like? What have you done to improve it?):
N/A.
Concerns (what feedback would you like?):
Should be safe.
Where should we start reviewing?:
diff
Priority (whenever / two weeks / yesterday):
ASAP.