Introduce Immutables Meta-Annotations

[jeremyk-91]

Goals (and why):

• Upgrade gradle-baseline.
• Introduce source retention for immutables style annotations: this should help to eliminate compilation warnings for consumers that do not directly depend on immutables.

Implementation Description (bullets):

• Switch to using meta-annotations that can be configured to be only retained in source jars.

Testing (What was existing testing like? What have you done to improve it?):

• Does it build? I think other than that the existing tests passing should be good enough evidence.

Concerns (what feedback would you like?):

• I've had to introduce one suppression to deal with https://app.circleci.com/pipelines/github/palantir/atlasdb/4136/workflows/4e239c84-9eac-4cba-b6c1-b0ebcc310f0f/jobs/23071.
• I think this is probably less readable than the original, though given the benefits (unblocking upgrades, prerequisite for more sensible annotation behaviour) it's worthwhile.

Where should we start reviewing?: ImmutablesStyles.java

Priority (whenever / two weeks / yesterday): this week please: not good to get behind on dependencies.

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Immutables style annotations now have source retention.

Check the box to generate changelog(s)

• Generate changelog entry

[anjor]

[akanekar@akanekar22-mac:atlasdb (jkong/package-visible-immutables)]$ grep -r "\@Value.Style" * atlasdb-client/src/main/java/com/palantir/atlasdb/table/description/TableMetadataStyle.java:@Value.Style(get = {"get*", "is*", "has*"}) atlasdb-commons/src/main/java/com/palantir/common/annotations/ImmutablesStyles.java: @Value.Style(visibility = Value.Style.ImplementationVisibility.PACKAGE) atlasdb-commons/src/main/java/com/palantir/common/annotations/ImmutablesStyles.java: @Value.Style(stagedBuilder = true) atlasdb-commons/src/main/java/com/palantir/common/annotations/ImmutablesStyles.java: @Value.Style(stagedBuilder = false) // Intentional: used for e.g. inner classes of staged builder public classes. atlasdb-commons/src/main/java/com/palantir/common/annotations/ImmutablesStyles.java: @Value.Style(allParameters = true) atlasdb-commons/src/main/java/com/palantir/common/annotations/ImmutablesStyles.java: @Value.Style(attributeBuilderDetection = true) timelock-agent/src/main/java/com/palantir/atlasdb/timelock/paxos/DoNotMatchInnerBuilderStyle.java:@Value.Style(typeInnerBuilder = "DoNotMatch") [akanekar@akanekar22-mac:atlasdb (jkong/package-visible-immutables)]$ grep -r "\@Style" * [akanekar@akanekar22-mac:atlasdb (jkong/package-visible-immutables)]$

looks like you got all of them!

[svc-autorelease]

Released 0.347.0