Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

[LW] Log the type of failed validation #5490

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Conversation

Jolyon-S
Copy link
Contributor

@Jolyon-S Jolyon-S commented Jun 7, 2021

Goals (and why):
It is currently impossible to determine which endpoint failed validation from the safe logs alone.

Implementation Description (bullets):
Log the endpoint that fails validation

Testing (What was existing testing like? What have you done to improve it?):
N/A

Concerns (what feedback would you like?):
It's a bit weird to use a constant string as a safe arg, but it works.

Where should we start reviewing?:
Diff

Priority (whenever / two weeks / yesterday):
ASAP.

@Jolyon-S Jolyon-S requested review from gmaretic and sudiksha27 June 7, 2021 09:18
@changelog-app
Copy link

changelog-app bot commented Jun 7, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Log the endpoint when lock watch cache validations fail.

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit 5d54c85 into develop Jun 7, 2021
@bulldozer-bot bulldozer-bot bot deleted the better-logging branch June 7, 2021 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants