This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
[PDS-146088] Force-clear the pool if no evictions are happening #5471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolyon-S
changed the title
[WIP] [PDS-146088] Force-clear the pool if no evictions are happening
[PDS-146088] Force-clear the pool if no evictions are happening
Jun 1, 2021
Generate changelog in
|
jeremyk-91
reviewed
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly makes sense. Two small suggested changes, and another that's more for if we want to productionise this. With those I'm not opposed to an RC, we can cut that tomorrow.
...a/src/main/java/com/palantir/atlasdb/keyvalue/cassandra/CassandraClientPoolingContainer.java
Outdated
Show resolved
Hide resolved
...a/src/main/java/com/palantir/atlasdb/keyvalue/cassandra/CassandraClientPoolingContainer.java
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
One symptom of PDS-146088 is that the client pool stops evicting. Force-clearing the pool if the eviction task has not even considered anything for eviction after some period of time is one approach that might work.
Implementation Description (bullets):
Clear the client pool if the last successful eviction run was over 15 minutes ago.
Testing (What was existing testing like? What have you done to improve it?):
No tests, which is perhaps dangerous, however I'm not sure what testing would or should look like here.
Concerns (what feedback would you like?):
As it stands, this PR is really bad - we need to also reset the last evicted time in the evictor, and the decomp is pretty wacky. I just wanted to get the concept down before I forgot.
Where should we start reviewing?:
CCPC.
Priority (whenever / two weeks / yesterday):
ASAP - we should get an RC out soon for internal testing.