Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

add dbkvs runtime password config #5365

Merged
merged 3 commits into from
Apr 7, 2021

Conversation

berler
Copy link
Contributor

@berler berler commented Apr 6, 2021

Goals (and why): Supports live password changes for products that use the standard atlas install and runtime config. Previously only products that had their own custom config and managed their own hikari pool could update the password at runtime. No behavior is changed when the new dbkvs runtime config is absent.

Implementation Description (bullets):

  • adds a new dbkvs runtime config
  • when the dbkvs runtime config is absent, behavior is the same as before
  • subscribes to the runtime config so that the hikari pool is updated any time the config changes

Testing (What was existing testing like? What have you done to improve it?):

Concerns (what feedback would you like?):

Where should we start reviewing?:

Priority (whenever / two weeks / yesterday): normal

berler added 2 commits April 6, 2021 14:34
This adds support for live reloading DB passwords for products that use
the standard install and runtime configs for Atlas. Note that previously
there was no dbkvs runtime config, so that has been added. When the
dbkvs runtime config is absent, behavior is identical to before (the
password from the install config is used).
@berler berler requested a review from jeremyk-91 April 6, 2021 21:57
@changelog-app
Copy link

changelog-app bot commented Apr 6, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

add dbkvs runtime password config

Goals (and why): Supports live password changes for products that use the standard atlas install and runtime config. Previously only products that had their own custom config and managed their own hikari pool could update the password at runtime. No behavior is changed when the new dbkvs runtime config is absent.

Implementation Description (bullets):

  • adds a new dbkvs runtime config
  • when the dbkvs runtime config is absent, behavior is the same as before
  • subscribes to the runtime config so that the hikari pool is updated any time the config changes

Testing (What was existing testing like? What have you done to improve it?):

Concerns (what feedback would you like?):

Where should we start reviewing?:

Priority (whenever / two weeks / yesterday): normal

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from tetigi April 6, 2021 21:57
Copy link
Contributor

@jeremyk-91 jeremyk-91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks reasonable, thanks!

@bulldozer-bot bulldozer-bot bot merged commit a0e0556 into develop Apr 7, 2021
@bulldozer-bot bulldozer-bot bot deleted the dbkvs-runtime-password-config branch April 7, 2021 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants