Allow configuring Cassandra servers in runtime configuration #5272
Conversation
There was a problem hiding this comment.
worth adding some tests? you can just take mine from https://github.com/palantir/atlasdb/pull/5249/files#diff-b9ef4433996a0706ed1d72c26d6f2334a45f0fd15425454bbedaed2d471b7d4dR170 if you wish
...a/src/main/java/com/palantir/atlasdb/cassandra/DelegatingCassandraKeyValueServiceConfig.java
Outdated
Show resolved
Hide resolved
pkoenig10
force-pushed
the
pkoenig10/servers
branch
3 times, most recently
from
b87e410 to
8faf31c
Compare
pkoenig10
force-pushed
the
pkoenig10/servers
branch
from
8faf31c to
ec93173
Compare
There was a problem hiding this comment.
Thanks for the solid implementation! This looks good to me as well.
It's important to note exactly what this change does. AtlasDB has a mechanism by which it discovers the Cassandra cluster. However, to bootstrap this and/or in the event of network failures, the config provides a list of initial contact points between AtlasDB and Cassandra. This change unlocks having that list of contact points update at runtime. Is this what you expect / will this be sufficient for what you're expecting more broadly?
|
Specifically for us, we just need the list of servers to be in runtime instead of install config. This PR more than satisfies that |
|
Released 0.301.2 |
Goals (and why):
Another (hopefully simpler) attempt at #5249, that I believe addresses all of the mentioned concerns.