Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Excavator: Upgrade dependencies #5233

Merged
merged 18 commits into from
Feb 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import com.google.common.collect.Streams;
import com.google.common.util.concurrent.Futures;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.MoreExecutors;
import com.palantir.atlasdb.timelock.NamespacedClients.ProxyFactory;
import com.palantir.atlasdb.timelock.api.MultiClientConjureTimelockService;
import com.palantir.atlasdb.timelock.api.management.TimeLockManagementService;
Expand Down Expand Up @@ -71,7 +72,15 @@ public TimeLockServerHolder serverHolder() {
}

ListenableFuture<Void> killAsync() {
return serverHolder.kill();
ListenableFuture<Void> kill = serverHolder.kill();
kill.addListener(
() -> {
// https://github.com/palantir/dialogue/issues/1119
clientsByNamespace.clear();
proxies.clearProxies();
},
MoreExecutors.directExecutor());
return kill;
}

void killSync() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import static org.assertj.core.api.Assertions.assertThat;

import com.palantir.conjure.java.api.errors.QosException;
import feign.RetryableException;
import com.palantir.conjure.java.api.errors.UnknownRemoteException;

public final class ExceptionMatchers {

Expand All @@ -27,6 +27,6 @@ private ExceptionMatchers() {}
public static void isRetryableExceptionWhereLeaderCannotBeFound(Throwable throwable) {
assertThat(throwable)
.hasRootCauseInstanceOf(QosException.RetryOther.class)
.isInstanceOf(RetryableException.class);
.isInstanceOf(UnknownRemoteException.class);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ int getPort(TimeLockServerHolder serverHolder) {
abstract int getPort(TimeLockServerHolder serverHolder);
}

public void clearProxies() {
proxies.clear();
}

public <T> T singleNode(TimeLockServerHolder server, Class<T> serviceInterface, ProxyMode proxyMode) {
return singleNode(server, serviceInterface, true, proxyMode);
}
Expand Down
Loading