This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
[PDS-158510] Improved Detection of Orphaned Sentinels #5231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
…db into jkong/sentinels-eveywhere
gmaretic
approved these changes
Feb 2, 2021
| } | ||
|
|
||
| @Test | ||
| public void getSweepSentinelUnderEarlyUncommittedWriteDoesNotThrow() { |
There was a problem hiding this comment.
should swap the names of this and the following test
There was a problem hiding this comment.
ah, you're right!
|
|
||
| @SuppressWarnings("unchecked") // ArgumentCaptor | ||
| @Test | ||
| public void getSentinelValuesStressTest() { |
| .collect(Collectors.toList()); | ||
| assertThat(stressTestRequests.get(index)).hasSizeLessThan(previousTimestamps.size()); | ||
| } | ||
| } |
There was a problem hiding this comment.
assert that retry succeeds?
There was a problem hiding this comment.
Yep, makes sense - added.
|
Released 0.290.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
Implementation Description (bullets):
Testing (What was existing testing like? What have you done to improve it?):
Added a new group of tests.
Concerns (what feedback would you like?):
Not much. Is perf a concern?
Where should we start reviewing?: Probably start with the tests
Priority (whenever / two weeks / yesterday): yesterday