This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Suppress deprecation warnings in generated code #5229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
pkoenig10
force-pushed
the
pkoenig10/deprecation
branch
from
2d7e7ce to
1015989
Compare
pkoenig10
force-pushed
the
pkoenig10/deprecation
branch
from
4982ed2 to
f7babea
Compare
|
We should fix these constants instead of suppressing because we do intend to remove the deprecated code in future releases. @gmaretic thoughts? |
gmaretic
approved these changes
Jan 28, 2021
|
Released 0.289.3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5169 deprecated some constants that were used in generated classes. While these generated classes do include
@SuppressWarnings("all"), that does not suppress javac lints such as-Xlint:deprecation. Those warnings need to be suppressed explicitly. For example, see jOOQ/jOOQ#2413.I've verified locally that this resolves the compilation issues with generated code.