Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

[Fix develop] Fix a potential deadlock in SweepQueueReader #5225

Merged
merged 3 commits into from
Jan 26, 2021
Merged

[Fix develop] Fix a potential deadlock in SweepQueueReader #5225

merged 3 commits into from
Jan 26, 2021

Conversation

carterkozak
Copy link
Contributor

Unsure how this passed baseline originally, but it's blocking
commits on develop.

I've searched internal sources and don't see any references
to the modified member.

@carterkozak
Fix a potential deadlock in SweepQueueReader
0029b7b 
Unsure how this passed baseline originally, but it's blocking
commits on develop.

I've searched internal sources and don't see any references
to the modified member.
@carterkozak
Add generated changelog entries
553655f
gmaretic
gmaretic approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@gmaretic gmaretic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this was merged before the baseline PR which was not rebased on develop!

@carterkozak
Copy link
Contributor Author

Thanks @gmaretic! This test failure looks like a flake and I don't have perms to retrigger it, any chance you could hit the button?

Once this goes through I'll rebase #5224

@carterkozak carterkozak mentioned this pull request Jan 26, 2021
Closed
@bulldozer-bot bulldozer-bot bot merged commit 4320a6a into develop Jan 26, 2021
@bulldozer-bot bulldozer-bot bot deleted the ckozak/fix_potential_deadlock branch January 26, 2021 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gmaretic gmaretic gmaretic approved these changes

Assignees
No one assigned
Labels
merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carterkozak @gmaretic