Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

[Cross Client Batching] Autobatchers support configurable wait strats #5197

Merged
merged 3 commits into from
Jan 15, 2021

Conversation

jeremyk-91
Copy link
Contributor

Goals (and why):

  • Minimise the performance overhead imposed by the use of an Autobatcher.

Implementation Description (bullets):

  • Expose a way of specifying wait strategy on the builder.

Testing (What was existing testing like? What have you done to improve it?):
Not much, sadly.

Concerns (what feedback would you like?):

  • There's an API break though we explicitly don't guarantee that that API will be preserved
  • Are the defaults chosen correctly?

Where should we start reviewing?: eh

Priority (whenever / two weeks / yesterday): this week?

@jeremyk-91 jeremyk-91 requested a review from sudiksha27 January 14, 2021 16:32
@changelog-app
Copy link

changelog-app bot commented Jan 14, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

AutobatcherBuilder now supports configurable wait strategies for the underlying Disruptor.

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@sudiksha27 sudiksha27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sudiksha27 sudiksha27 merged commit ac06f02 into develop Jan 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the jkong/disruptor-configurable-wait-strats branch January 15, 2021 09:40
@svc-autorelease
Copy link
Collaborator

Released 0.285.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants