This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
[LW] Don't compare Longs using == #5039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
Jolyon-S
commented
Oct 16, 2020
Comment on lines
-365
to
+370
| .isExactlyInstanceOf(TransactionLockWatchFailedException.class); | ||
| .isExactlyInstanceOf(TransactionLockWatchFailedException.class) | ||
| .hasMessage("Events do not enclose the required versions"); | ||
|
|
||
| assertThatThrownBy(() -> eventCache.getCommitUpdate(START_TS)) | ||
| .isExactlyInstanceOf(TransactionLockWatchFailedException.class); | ||
| .isExactlyInstanceOf(TransactionLockWatchFailedException.class) | ||
| .hasMessage("start or commit info not processed for start timestamp"); |
There was a problem hiding this comment.
drive by to make more specific.
jkozlowski
approved these changes
Oct 16, 2020
|
Released 0.253.3 |
This was referenced Oct 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
Read the title.
Implementation Description (bullets):
Use
equalsinstead.Testing (What was existing testing like? What have you done to improve it?):
Added a test that actually triggers the bad case (when using ==).
Concerns (what feedback would you like?):
DID WE MISS ANYTHING ELSE
Where should we start reviewing?:
ClientLogEventsPriority (whenever / two weeks / yesterday):
yesterday 🔥