Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

[LW] Check for bad version in the right place #5031

Merged
merged 5 commits into from
Oct 14, 2020
Merged

Conversation

Jolyon-S
Copy link
Contributor

Goals (and why):

  • Fix a bug that can occur on leader elections

Implementation Description (bullets):

  • Move the check inside a block where we've already checked for mismatched leaders, and make it non-retriable.

Testing (What was existing testing like? What have you done to improve it?):

  • Added yet another test in the integration tests.

Concerns (what feedback would you like?):
This fixes the issue, right?

Where should we start reviewing?:
LockWatchEventCacheImpl

Priority (whenever / two weeks / yesterday):
yesterday 🔥

@changelog-app
Copy link

changelog-app bot commented Oct 14, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Fix LockWatch bug where a leader election could cause all requests to get updates to fail.

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit f6d796d into develop Oct 14, 2020
@bulldozer-bot bulldozer-bot bot deleted the lets-not-fail branch October 14, 2020 13:10
@svc-autorelease
Copy link
Collaborator

Released 0.252.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants