This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Leader election slos #4974
Merged
Leader election slos #4974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
gmaretic
approved these changes
Sep 8, 2020
changelog/@unreleased/pr-4974.v2.yml
Outdated
| @@ -0,0 +1,6 @@ | |||
| type: improvement | |||
leader-election-impl/src/main/java/com/palantir/leader/health/LeaderElectionHealthCheck.java
Show resolved
Hide resolved
| private static final double MAX_ALLOWED_LAST_5_MINUTE_RATE = 0.016; | ||
| private static final double MAX_ALLOWED_LAST_5_MINUTE_RATE = 0.015; | ||
| private final ConcurrentMap<Client, LeaderElectionServiceMetrics> clientWiseMetrics | ||
| = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
nit: one line, and extra newline
|
|
||
| private final LeaderElectionServiceMetrics leaderElectionServiceMetrics; | ||
| public void registerClient(Client namespace, |
| private final LeaderElectionHealthCheck leaderElectionHealthCheck = | ||
| new LeaderElectionHealthCheck(leaderElectionServiceMetrics); | ||
| private final LeaderElectionHealthCheck leaderElectionHealthCheck = new LeaderElectionHealthCheck(); | ||
| private static final Client CLIENT = Client.of("abc"); |
There was a problem hiding this comment.
Add a test with multiple clients
|
LGTM! |
|
Released 0.245.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
Fix bug with leader election rate health check. The health check should be analyzing the metrics per client.
Implementation Description (bullets):
Register client wise metrics to leader election rate health check.
Leader election health check performs analysis on the sum of rates of all clients
Testing (What was existing testing like? What have you done to improve it?):
Tested on internal testing environment
Concerns (what feedback would you like?):
Does the wiring make sense?
Where should we start reviewing?:
LeaderElectionHealthCheck.java, TimeLockAgent.java
Priority (whenever / two weeks / yesterday):
As soon as possible 🔥