This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Remove local vs remote host selected metric #4922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
…db into remove-local-host-metrics
jkozlowski
reviewed
Jul 29, 2020
| @@ -93,10 +87,6 @@ public CassandraService( | |||
| Blacklist blacklist, | |||
| CassandraClientPoolMetrics poolMetrics) { | |||
| this.metricsManager = metricsManager; | |||
There was a problem hiding this comment.
I'm wondering if instead you could do @jeremyk-91 's filtering? So filter when this is 1, but publish when it's not?
There was a problem hiding this comment.
I'm removing it more because I don't think I have ever used it after the initial rollout. So even if we filter it, would it be used in debugging?
There was a problem hiding this comment.
I've seen it go down and slowly recover before. But I think you might be right, there might not be any in keeping the complexity here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
Our internal fleet has long since moved to using the local weighting of 1.0, so this metric generally just shows a straight line all of the time.
Implementation Description (bullets):
Removed counters recording when local or remote host was selected.
Testing (What was existing testing like? What have you done to improve it?):
N/A.
Concerns (what feedback would you like?):
Does anyone actually look at this metric, and/or is it ever useful?
Where should we start reviewing?:
CassandraServicePriority (whenever / two weeks / yesterday):
Whenever