Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

[PDS-127121] Log refreshed Cassandra hosts at info level #4917

Merged
merged 5 commits into from
Jul 28, 2020
Merged

[PDS-127121] Log refreshed Cassandra hosts at info level #4917

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
15cf846
set debug logging to info
Jolyon-S Jul 27, 2020
866886e
Add generated changelog entries
Jolyon-S Jul 27, 2020
dc3ce65
factor out log method
Jolyon-S Jul 27, 2020
c001782
Merge branch 'elevate-to-info' of github.com:palantir/atlasdb into el…
Jolyon-S Jul 27, 2020
d20c26f
make method static
Jolyon-S Jul 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...sandra/src/main/java/com/palantir/atlasdb/keyvalue/cassandra/CassandraClientPoolImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ private void setServersInPoolTo(Set<InetSocketAddress> desiredServers) {
cassandra.refreshTokenRangesAndGetServers();
}

log.debug("Cassandra pool refresh added hosts {}, removed hosts {}.",
log.info("Cassandra pool refresh added hosts {}, removed hosts {}.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: How valuable is an empty refresh line? Maybe we can have a refresh that did something at INFO and a refresh that did nothing at DEBUG.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

SafeArg.of("serversToAdd", CassandraLogHelper.collectionOfHosts(serversToAdd)),
SafeArg.of("serversToRemove", CassandraLogHelper.collectionOfHosts(serversToRemove)));
}
Expand Down
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-4917.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: improvement
improvement:
description: Log refreshed Cassandra hosts at info level instead of debug.
links:
- https://github.com/palantir/atlasdb/pull/4917