[Dialogue] Part 12: Fix Misdeclared Product Dependencies

[jeremyk-91]

Goals (and why):

• @jackwickham notes that the product dependencies were not set up correctly for AtlasDB users of internal TimeLock. The main problem is that these were applied to the lock-conjure-api project, not its subprojects. The version was also inconveniently two versions too early.

Implementation Description (bullets):

• Declare the product dependencies as pertaining to the scope of subprojects.

Testing (What was existing testing like? What have you done to improve it?):

• I built the artifacts and read the manifest of the jars. No automated test written here.

Concerns (what feedback would you like?):

• Should more aggressive corrective action be taken internally? I doubt it given that in spite of potentially incorrect dependencies, all monitored internal stacks are past the true minimum version needed.

Where should we start reviewing?: build.gradle

Priority (whenever / two weeks / yesterday): this week please

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

The Conjure version of the V1 lock service now correctly depends on a version of TimeLock server that exposes these endpoints. Previously this wasn't the case, and a service which attempted to use the Conjure version would run into 404s when attempting to acquire or release locks.

Check the box to generate changelog(s)

• Generate changelog entry

[sudiksha27]

👍

[svc-autorelease]

Released 0.227.5