Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

[PDS-119625] Log the Exception, not UnsafeArg.of(exceptionMessage) #4822

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

jeremyk-91
Copy link
Contributor

Goals (and why):

  • See PDS-119625
  • This made debugging somewhat annoying: you lose the failure type stack trace (and in the event t is actually Safe, you lose all information!)

Implementation Description (bullets):

  • Log the exception, not UnsafeArg.of(exceptionMessage).

Testing (What was existing testing like? What have you done to improve it?): none

Concerns (what feedback would you like?):

  • This may increase logging payloads. It won't pollute the logs from a user PoV so this would primarily be in terms of logging infra. I think the cost is reasonable.

Where should we start reviewing?: CCPC

Priority (whenever / two weeks / yesterday): this week

@jeremyk-91 jeremyk-91 requested a review from sudiksha27 June 4, 2020 10:07
@changelog-app
Copy link

changelog-app bot commented Jun 4, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

The type and stack trace of Exceptions when talking to Cassandra are now logged (and in the case of Safe exceptions, the exception message will also be available). Previously, only the exception message was logged, and this was always Unsafe.

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit c488c75 into develop Jun 8, 2020
@bulldozer-bot bulldozer-bot bot deleted the jkong/119625 branch June 8, 2020 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants