[Dialogue] Part 1: BlockingSensitive -> TimeoutSensitive Nomenclature Changes

[jeremyk-91]

Goals (and why):

• Change nomenclature to identify former Atlas-named blocking and non blocking services as having long and short timeouts respectively. The intuition there was that the blocking ones might be slow for reasons outside of the request's or server's control - in a sense they block on external resources - but the Dialogue generated code already uses Blocking to mean whether the client blocks. In this sense all AtlasDB connection to timelock currently is blocking on the client side.

Implementation Description (bullets):

• Rename BlockingAndNonBlockingServices to ShortAndLongTimeoutServices
• Rename general usages of blocking and non-blocking in the above context to having long/extended or short timeouts.
• Drive by deletion of unused class (including in large internal product, I checked).

Testing (What was existing testing like? What have you done to improve it?):

• Updated existing tests with new naming. Shouldn't change behaviour and should already be covered.

Concerns (what feedback would you like?):

• Were any uses of the old nomenclature missed out?
• Did I accidentally change blocking or non-blocking in a sense not captured by the above inappropriately?

Where should we start reviewing?: TransactionManagers

Priority (whenever / two weeks / yesterday): tomorrow please

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

AuxiliaryRemotingParameters#shouldSupportBlockingOperations is now changed to AuxiliaryRemotingParameters#shouldUseExtendedTimeout. This is done to avoid confusion with Dialogue generated code where blocking indicates that client requests should wait till competion. You should only be affected if you provide these parameters and construct HTTP clients through AtlasDbHttpClients directly.

Check the box to generate changelog(s)

• Generate changelog entry

[gmaretic]

Looks good, found some outdated comments so fixed it!

[svc-autorelease]

Released 0.218.0